Image upload to hactrn.kostersitz.com is corrupted

[oilcan-productions]

          @oilcan-productions, I often get this now.  If I rerun the build 1-2 times it will usually work.  Any idea why?

Originally posted by @larsbrinkhoff in #2294 (comment)

[oilcan-productions]

Checked the server side logs, show Client disconnected, nothing more.
I opened a support ticket to see if there is throttling happening in the background somewhere

[oilcan-productions]

They fixed an error in the quota settings file (should be unlimited and was set to 250MB and 4 concurrent connections) of the home path of the account we use to upload. Now it should be unlimited around. @larsbrinkhoff can you kick off a build and see if that resolved the issue?

[larsbrinkhoff]

Thanks. I started rebuild of the latest commit on master: https://github.com/PDP-10/its/actions/runs/8651430739

[larsbrinkhoff]

The restarted build failed for three out of six targets, due to the FTP check. It's a good thing you added that verification! Still, the upload goes wrong sometimes, apparently.

(Since we need "make download" to work, I reran the builds until they passed, so now everything is green again.)

[oilcan-productions]

@larsbrinkhoff I am seeing the build right now not deploying at all to the FTP server, as well as the Ubuntu build failing before it gets to the deploy stage.

[larsbrinkhoff]

Only commits on master will run the deploy script. I have merged the pull request now; here's the build to watch: https://github.com/PDP-10/its/actions/runs/8905672868

[larsbrinkhoff]

Here's a curious case: your retry mechanism kicked in, but two targets reached the limit.
https://github.com/PDP-10/its/actions/runs/8948158873

The other four worked on the first try.

[larsbrinkhoff]

And then the next build went perfectly fine. No retries needed.
https://github.com/PDP-10/its/actions/runs/8953189776

[oilcan-productions]

Added to the retry logic to recreate the tarball upon retry to ensure it is actually correct.