Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYSENG;CTIMSR appears to incorrectly call .logout #2292

Open
eswenson1 opened this issue Mar 14, 2024 · 1 comment
Open

SYSENG;CTIMSR appears to incorrectly call .logout #2292

eswenson1 opened this issue Mar 14, 2024 · 1 comment

Comments

@eswenson1
Copy link
Member

Has the following subroutine (accessed via JSR):

LOGOUT: 0
        SKIPL DEBUG
         .LOGOUT
        .VALUE

The intent is to kill the job unless the DEBUG flag is set (to a negative value). So if DEBUG is 0, we invoke .LOGOUT, which is supposed to kill the job if it is top-level. However, .logout with no AC specified, or an AC of 0 specified, will only kill top-level jobs. The job won't exit if it is an inferior job. For that, the code should be:

.LOGOUT 1,

I'm not sure if it really matters, since it only impacts people running it as an inferior job (e.g. for debugging), and when they do, they would normally set DEBUG to -1. However, I was trying to figure out why the job was not working reliably, and happened to notice that when DEBUG was 0, the job didn't terminate.

@eswenson1
Copy link
Member Author

@larsbrinkhoff Your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant