Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated html5ever version required by soup produces future-incompatibilities warning #10

Open
0323pin opened this issue Oct 1, 2023 · 1 comment

Comments

@0323pin
Copy link
Contributor

0323pin commented Oct 1, 2023

Just as an heads-up. Building with Rust-1.72.0 spits-out the following warning:

   Compiling bandsnatch v0.3.0 (/usr/pkgsrc/wip/bandsnatch/work/bandsnatch-0.3.0)
warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` instead
  --> src/api/structs/digital_item.rs:50:34
   |
50 |             Some(d) => match Utc.datetime_from_str(d, FORMAT) {
   |                                  ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: function `command` is never used
  --> src/cmds/release.rs:18:14
   |
18 | pub async fn command(_args: Args) -> Result<(), Box<dyn std::error::Error>> {
   |              ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: `bandsnatch` (bin "bandsnatch") generated 2 warnings
    Finished release [optimized] target(s) in 9m 01s
warning: the following packages contain code that will be rejected by a future version of Rust: html5ever v0.22.5
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
@Ovyerus
Copy link
Owner

Ovyerus commented Oct 1, 2023

Looks like it's caused by an older version of html5ever being required by soup, but it hasn't been updated yet (relevant issue).

It does look like soup hasn't been updated in a while though (last commit was a few years ago, and there's an open PR for doing this specific thing that is 3 years old too, I might have to look into swapping libraries or forking it myself.

@Ovyerus Ovyerus changed the title future-incompatibilities Outdated html5ever version required by soup produces future-incompatibilities warning Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants