Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing claim for ngx.ctx.authenticated_consumer #28

Open
arwineap opened this issue Feb 23, 2023 · 0 comments
Open

Missing claim for ngx.ctx.authenticated_consumer #28

arwineap opened this issue Feb 23, 2023 · 0 comments

Comments

@arwineap
Copy link

It is more important to sign the data that kong has derived, and therefore is the authoritative source for; than signing the untrusted data that was passed into the http request. Additionally, it seems like ngx.ctx.authenticated_consumer was intended to be used, as it's specified here:
https://github.com/Optum/kong-upstream-jwt/blob/master/src/handler.lua#L9

Would you support a PR that added a config to enable ngx.ctx.authenticated_consumer to be added as a claim in the jwt?

Alternatively, a more generic solution may be to allow users to configure a set of headers to be added to claims, some previous discussion here:
#15
#16

Would you support a PR that implemented an optional additional_header_claims config that allowed custom headers to be added?

Let me know what you think, I would love to help support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant