Existing dynamic keyboards broken on origin/master

[kmcnaught]

The commit: 25f5d16 breaks one of my existing keyboards. @AdamRoden was it supposed to introduce any functional changes?

Keyboard file - vscode.txt

Before 25f5d16, this keyboard loads like this:

After 25f5d16, I get the error "insufficient space to position item 17 of 81 with symbol "BackIcon" at row 0 column 15"

(Note that some of the keys won't work as I've added some functionality in a separate branch, I'm just interested in whether it loads okay)

[AdamRoden]

@kmcnaught
I changed the algorithm to process all keys in the same order they are listed in the xml file regardless of whether they have row/col defined. There main reason was that from a user perspective it makes more sense that when one key has a row/col defined and the next key doesn't that the next key will be placed in the next available spot rather than starting the search from the top left of all unallocated space.

So, basically, you would either need to have your Back key somewhere before your Clear key, or you would need to assign a row to your "Clear" to tell the algorithm to start filling a different row, and then when it gets to your Back key it will jump backwards to that position and start filling adjacent empty space from there.

All that said, I could probably make it allocate space for certain keys, but also include them as logical "move to indicators" when the full list of keys is processed in order.

[AdamRoden]

@kmcnaught This commit fixes that issue, but a lot of other stuff is still in progress. With it, I loaded your keyboard into my designer and then saved it with my current schema to the attached file.
AdamRoden@cd02eae
vscode2.txt