Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launching directly into a dynamic keyboard doesn't respect overridden WindowState #857

Open
kmcnaught opened this issue Aug 24, 2022 · 1 comment
Open

Launching directly into a dynamic keyboard doesn't respect overridden WindowState #857

kmcnaught opened this issue Aug 24, 2022 · 1 comment

Comments

@kmcnaught
Copy link
Collaborator

  • Optikey is set to "Docked", but to start up directly with a dynamic keyboard with <WindowState>Maximised</WindowState>
  • The keyboard starts up docked, not maximised.

I have a suspicion this might also happen when using a built-in maximised keyboard (ie Conversation) - need to test.

top.zip
@alexandre-mbm
Copy link
Contributor

alexandre-mbm commented Sep 1, 2022 •
edited

Seems this 5895745 commit's logic needs updating.

alexandre-mbm referenced this issue Sep 3, 2022
@mark-poscablo
Correct logic for fixing the minimised restore bug
5895745 
Also extracted the logic out of the constructor to a new function.
Correct logic described by JuliusSweetland and was tested by
mark-poscablo
@alexandre-mbm alexandre-mbm mentioned this issue Sep 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexandre-mbm @kmcnaught