Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce custom Exceptions #17

Open
marvin-we opened this issue Sep 9, 2020 · 1 comment
Open

Introduce custom Exceptions #17

marvin-we opened this issue Sep 9, 2020 · 1 comment
Assignees
Labels
High High priority

Comments

@marvin-we
Copy link
Contributor

SQ and VSCode complain about using plain Exceptions - Any thoughts about this?

In case we want to fix it:

  • Where to store them?
  • Is there any hierarchy we want to create?
@marvin-we marvin-we added the High High priority label Sep 10, 2020
@marvin-we
Copy link
Contributor Author

I have some things in mind where we can do different actions based on the Exception type. One concrete sample is the 'getClient' method of the 'ConnectionManager' - If we throw a dedicated Exception here, the 'CommunicationHandler' would be allowed to distinguish between:

  • A general issue with the connection
  • The fact that there is simply no client available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High High priority
Projects
None yet
Development

No branches or pull requests

2 participants