Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy) #434

Closed
1 of 4 tasks
0xNeshi opened this issue Dec 5, 2024 · 2 comments · Fixed by #440
Closed
1 of 4 tasks

[Feature]: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy) #434

0xNeshi opened this issue Dec 5, 2024 · 2 comments · Fixed by #440
Assignees
@SarveshLimaye
Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request. type: ref A code update that doesn't meaningfully change functionality.

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Dec 5, 2024 •
edited
Loading

What is the feature you would like to see?

Slack discussion.
In short, the team agreed we would not be supporting reentrant patterns.

Doing this will enable us to remove TopLevelStorage impls from most, if not all contracts.

TODO:

  • Turn all Call::new_in into Call::new calls (wherever applicable).
  • Update all functions that were &mut self only because of using Call::new_in to now be just &self.
  • Remove TopLevelStorage impls wherever possible.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request. good first issue Good for newcomers. effort: medium Default level of effort. type: ref A code update that doesn't meaningfully change functionality. labels Dec 5, 2024
@SarveshLimaye
Copy link
Contributor

Hey @0xNeshi , Can I work on this issue?

@0xNeshi
Copy link
Collaborator Author

0xNeshi commented Dec 6, 2024

Hi @SarveshLimaye , you're more than welcome to work on this!

@SarveshLimaye SarveshLimaye mentioned this issue Dec 9, 2024
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Rust Contracts Stylus Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SarveshLimaye SarveshLimaye

Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request. type: ref A code update that doesn't meaningfully change functionality.
Projects
Rust Contracts Stylus
Status: Done
Milestone
No milestone
2 participants
@0xNeshi @SarveshLimaye