Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: ERC20FlashMint extension #355

Closed
1 task done
bidzyyys opened this issue Oct 17, 2024 · 0 comments · Fixed by #407
Closed
1 task done

[Feature]: ERC20FlashMint extension #355

bidzyyys opened this issue Oct 17, 2024 · 0 comments · Fixed by #407
Assignees
@0xNeshi
Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request.

Comments

@bidzyyys
Copy link
Collaborator

What is the feature you would like to see?

Add ERC20FlashMint extension (solidity).

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@bidzyyys bidzyyys added priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request. good first issue Good for newcomers. effort: medium Default level of effort. labels Oct 17, 2024
@Ifechukwudaniel Ifechukwudaniel mentioned this issue Nov 14, 2024
Merged
3 tasks
@0xNeshi 0xNeshi self-assigned this Dec 10, 2024
@0xNeshi 0xNeshi mentioned this issue Dec 18, 2024
Merged
0xNeshi pushed a commit that referenced this issue Dec 18, 2024
@qalisander
revert: "feat: Turn All Call::new_in into Call::new (i.e. Stop Su…
4de08e5 
…pporting Reentrancy) (#440)" (#464)

Towards #355

Reentrancy is necessary for Erc20FlashMint.

refs: da0249b
bidzyyys added a commit that referenced this issue Jan 7, 2025
@Ifechukwudaniel @0xNeshi
@bidzyyys @qalisander
feat: add ERC20FlashMint extension (#407)
9d0a466 
<!--
Thank you for your interest in contributing to OpenZeppelin!

Consider opening an issue for discussion prior to submitting a PR. New
features will be merged faster if they were first discussed and designed
with the team.

Describe the changes introduced in this pull request. Include any
context necessary for understanding the PR's purpose.
-->

**NOTE: It is impossible to write any unit tests until it is possible to
mock `contract::address()` in tests (see
OpenZeppelin/stylus-test-helpers#5

<!-- Fill in with issue number -->
Resolves #355

#### PR Checklist

<!--
Before merging the pull request all of the following must be completed.
Feel free to submit a PR or Draft PR even if some items are pending.
Some of the items may not apply.
-->

- [x] Tests
- [x] Documentation
- [x] Changelog

---------

Co-authored-by: Nenad <[email protected]>
Co-authored-by: Nenad <[email protected]>
Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Alisander Qoshqosh <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in Rust Contracts Stylus Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xNeshi 0xNeshi

Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request.
Projects
Rust Contracts Stylus
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ERC20FlashMint extension Ifechukwudaniel/rust-contracts-stylus
2 participants
@0xNeshi @bidzyyys