Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap OTIO base classes in Java interfaces or abstract class instead of classes #32

Open
KarthikRIyer opened this issue Sep 3, 2021 · 1 comment

Comments

@KarthikRIyer
Copy link
Contributor

KarthikRIyer commented Sep 3, 2021

OTIO classes like Composition and Item can be wrapped in Java interfaces or abstract class instead of classes to make it explicit that they are not to be used directly, but through subclasses. If there's any useful logic in these base classes we can provide default implementation in the interface as shown here.

@KarthikRIyer KarthikRIyer changed the title Wrap OTIO base classes in Java interfaces instead of classes Wrap OTIO base classes in Java interfaces or abstract class instead of classes Sep 4, 2021
@KarthikRIyer
Copy link
Contributor Author

@reinecke classes like Composition and Item have functions which do not have an implementations and should be subclassed for actual use. In the python bindings why don't we make them abstract methods?

Is there any situation where someone would use Composable, Composition, Item, SerializableObject, SerializableObjectWithMetadata directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant