Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected dependency on shell REVBIN variable. #8

Open
kfogel opened this issue Jul 27, 2019 · 0 comments
Open

Unexpected dependency on shell REVBIN variable. #8

kfogel opened this issue Jul 27, 2019 · 0 comments

Comments

@kfogel
Copy link
Member

kfogel commented Jul 27, 2019

I think as of commit 8463ab1 we've been depending on the shell having a REVBIN variable in it. I agree, by the way, that the version of the Makefile prior to that commit had a buggy line for assigning REVBIN -- what was there wasn't always going to work either. But the new line assumes that REVBIN is set in the surrounding shell, which at least for me is not the case. If we were going to have that variable, we would probably want to call it OTS_REVBIN or something like that anyway (similarly to OTSDIR and OTS_DOCTOOLS_DIR).

It's not a showstopper currently because it only matters for .draft.pdf outputs -- that is, outputs with the "DRAFT" watermark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant