Fix #12591: Give descriptive error when station construction fails due to wrong layout #12678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not have two error messages? The "or" makes the error message vague and confusing |
|
Hmm, good point. |
2TallTyler
force-pushed
the
station-layout-error
branch
from
9ac7bf9
to
7a6e2e2
Compare
|
Still feels a bit vague though... would it be overly specific to be something like "...layout cannot be this many platforms" ? & also for the other message |
|
"... unsupported station layout" |
…ails due to wrong layout
2TallTyler
force-pushed
the
station-layout-error
branch
from
7a6e2e2
to
4063f59
Compare
2TallTyler
added
the
backport requested
rubidium42
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Per #12591, some NewGRF station sets require a specific arrangement of tiles for certain station layouts.
Using drag-and-drop construction, the player can try to build a different tile arrangement, like only one tile for a station layout that requires two tracks. This fails, but only returns a generic error message.
Description
Return a descriptive error message.
Closes #12591.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.