Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in custom layout for the display don't update in real-time #965

Closed
dangerousdonut opened this issue Apr 12, 2024 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@dangerousdonut
Copy link

dangerousdonut commented Apr 12, 2024

Expected Behavior

When going into the display configuration and choosing to show a custom button layout, you can move elements around (Start X, Start Y, etc.) and changes in these parameters would immediately be updated on the OLED display.

Current Behavior

Currently, in 0.7.8, making changes to the placement of a custom button layout isn't reflected until you save changes and reboot the device. However, in 0.7.7 changes in these parameters would still update in real time.

(Additionally, probably a separate issue, in 0.7.8 the button padding setting doesn't change the distance between buttons as it did in 0.7.7. It behaves unpredictably. For the left button layout, it seems to not work at all, while for the right layout it changes the vertical placement of the buttons.)

Context

  • Firmware version: 0.7.8 (GP2040-CE_0.7.8_Haute42COSMOX.uf2)
  • Board config name: Haute 42 COSMOX
  • Name of device: Haute42 Hautepad P12
  • Link to where you purchased the device: https://aliexpress.com/item/1005006780720770.html
  • Operating System: Windows 10 (22H2)
  • Browser: Mozilla Firefox 124.0.2

Steps to Reproduce

  1. Update to 0.7.8 (Haute42 COSMOX version)
  2. In web-config, go into Configuration > Display Configuration
  3. Under Layout Options, change Button Layout Left & Right to the Custom setting
  4. Press B1 on the hardware to see button layout on the OLED
  5. Changing the various custom parameters in web-config, like Star X, isn't reflected immediately on the screen
  6. Additionally, the Button Padding option doesn't change distance between button icons

Screenshots & Files

(If needed I can make a video, but I think the above covers the essentials.)

@dangerousdonut dangerousdonut added the bug Something isn't working label Apr 12, 2024
@TheTrainGoes
Copy link
Contributor

This is due to our re-write of the display back end.

We will look to fix this for v0.7.9.

@mikepparks
Copy link
Contributor

Please confirm if the behavior still exists in PR #974.

@dangerousdonut
Copy link
Author

dangerousdonut commented Apr 25, 2024

Please confirm if the behavior still exists in PR #974.

I'm not sure how I would test it 😅

@TheTrainGoes
Copy link
Contributor

Hi @dangerousdonut ,

You would need to go to the action for that PR, download the artifact, extract, nuke and try on your device.

If thats not something you are comfortable doing then please wait until our new RC run before v0.7.9.

@TheTrainGoes
Copy link
Contributor

No answer from original poster, this is resolved in #974 from our testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants