-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving Protobuf breaks Core0 functionality #867
Comments
I'll take point on this one since I've been doing a lot of core revamping. |
Is it because protobuf is complicated, or is it because FlashPROM locks the cores when writing? |
@arntsonl --- https://github.com/OpenStickCommunity/GP2040-CE/blob/main/lib/FlashPROM/src/FlashPROM.cpp#L16 is what I mean, by the way. I would have to look at nanopb but I would be surprised if the serialization was a major problem, since the config is already in a struct at runtime and just has to be packed in order to be written. |
Oooooh I'm not sure! That will have to be part of the investigation |
Prerequisites
Please check the following before posting an issue / bug report.
Context
Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.
Expected Behavior
Protobuf should be able to save via the Save() system without breaking any functionality on the GP2040 project.
Current Behavior
Save() causes everything to lock up including the tud_task and tuh_task calls because of how complex protobuf is. This should be moved over to Core1 if possible to leave Core0's usb processing abilities.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.
Screenshots & Files
Please include any relevant screenshots or files here. If you are having issues with a board please include images of the front and back of the board.
The text was updated successfully, but these errors were encountered: