Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address and port to constructor in JavaScript API #3264

Open
engbergandreas opened this issue May 17, 2024 · 2 comments
Open

Add address and port to constructor in JavaScript API #3264

engbergandreas opened this issue May 17, 2024 · 2 comments
Labels
Component: Core Issues that are related to the core of OpenSpace Type: Enhancement Extending the functionality of already existing features

Comments

@engbergandreas
Copy link
Member

We should update the JavaScript API to accept a port and address without having to create and import the socket module separately, similar to what we did we the Python API.

@engbergandreas engbergandreas added the Type: Enhancement Extending the functionality of already existing features label May 17, 2024
@engbergandreas
Copy link
Member Author

Might actually be uneccessary since the module.exports handles it

@micahnyc
Copy link
Contributor

yeah I think we have this. Basically when I use the api I do something like this:

var api = window.openspaceApi(host, 4682);

@alexanderbock alexanderbock added the Component: Core Issues that are related to the core of OpenSpace label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Issues that are related to the core of OpenSpace Type: Enhancement Extending the functionality of already existing features
Projects
None yet
Development

No branches or pull requests

3 participants