Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition between FFMpegWriter and ImageWriter tests #933

Open
Ninpo opened this issue Jul 9, 2023 · 1 comment
Open

Race condition between FFMpegWriter and ImageWriter tests #933

Ninpo opened this issue Jul 9, 2023 · 1 comment
Labels
stale This issue has not had any activity in 90 days :(

Comments

@Ninpo
Copy link
Contributor

Ninpo commented Jul 9, 2023 •
edited

It's possible when tests are run in parallel for the FFmpegWriter:Gif and ImageWriter:Gif tests to collide due to creation of the same file, output1.gif.

Discovered over at Gentoo Linux during version bump to 0.3.2: https://bugs.gentoo.org/909759

PR submitted with suggested fix.
Ninpo added a commit to Ninpo/gentoo that referenced this issue Jul 9, 2023
@Ninpo
media-libs/libopenshot: Two test fixes
ca7144b 
* Fix parallel test issues by renaming the output files
  to avoid clobbering (reported upstream at
  OpenShot/libopenshot#933)

* Skip flaky test (reported upstream at OpenShot/libopenshot#934)

Closes: https://bugs.gentoo.org/909759
Signed-off-by: Ninpo <[email protected]>
@Ninpo Ninpo mentioned this issue Jul 9, 2023
Closed
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Jul 9, 2023
@Ninpo @thesamesam
media-libs/libopenshot: Two test fixes
d97b4ec 
* Fix parallel test issues by renaming the output files
  to avoid clobbering (reported upstream at
  OpenShot/libopenshot#933)

* Skip flaky test (reported upstream at OpenShot/libopenshot#934)

Closes: https://bugs.gentoo.org/909759
Signed-off-by: Ninpo <[email protected]>
Closes: #31810
Signed-off-by: Sam James <[email protected]>
Ninpo added a commit to Ninpo/libopenshot that referenced this issue Jul 9, 2023
@Ninpo
Fixes test file collisions with high concurrency builds
a6f9f73 
Fix by Ninpo <[email protected]>

OpenShot#933
@Ninpo Ninpo mentioned this issue Jul 9, 2023
Merged
Ninpo added a commit to Ninpo/libopenshot that referenced this issue Jul 9, 2023
@Ninpo
Fixes test file collisions with high concurrency builds
711e3e4 
Fix by Ninpo <[email protected]>

When tests are run in parallel it's possible for ImageWriter
and FFmpegWriter Gif tests to truncate/overwrite the other's
output1.gif. This change makes use of test file names unique
to the tests themselves.

OpenShot#933
Ninpo added a commit to Ninpo/libopenshot that referenced this issue Jul 9, 2023
@Ninpo
Fixes test file collisions with high concurrency builds
e17c2a3 
Fix by Ninpo <[email protected]>

When tests are run in parallel it's possible for ImageWriter
and FFmpegWriter Gif tests to truncate/overwrite the other's
output1.gif. This change makes use of test file names unique
to the tests themselves.

Because cmake defaults to Makefiles and make does not -j$(nproc)
by default, this bug can't show up unless part of a build with parallel
make with tests included.

OpenShot#933
@stale
Copy link

stale bot commented Oct 15, 2023

Thank you so much for submitting an issue to help improve OpenShot Video Editor. We are sorry about this, but this particular issue has gone unnoticed for quite some time. To help keep the OpenShot GitHub Issue Tracker organized and focused, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.

This issue will be closed, as it meets the following criteria:

  • No activity in the past 90 days
  • No one is assigned to this issue

We'd like to ask you to help us out and determine whether this issue should be reopened.

  • If this issue is reporting a bug, please can you attempt to reproduce on the latest daily build to help us to understand whether the bug still needs our attention.
  • If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.

Thanks again for your help!

@stale stale bot added the stale This issue has not had any activity in 90 days :( label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale This issue has not had any activity in 90 days :(
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ninpo