Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getWaveformData in Clip; expose RMS data in Frame #156

Open
DerGenaue opened this issue Aug 26, 2018 · 0 comments
Open

Implement getWaveformData in Clip; expose RMS data in Frame #156

DerGenaue opened this issue Aug 26, 2018 · 0 comments

Comments

@DerGenaue
Copy link

DerGenaue commented Aug 26, 2018

The libopenshot-audio: AuidoSampleBuffer provides a getRMS-Method that isn't exposed by the libopenshot Frame.

This should be changed, in my opinion.

Also, together with this, a generator for waveform-data should be implemented in the Clip.cpp:
(Mostly to replace the python function get_waveform of openshot-qt)

I would propose eg.

float* Clip::GetWaveformData(int samples_per_second, int channel, int start_frame, int end_frame);

Which returns both Max and RMS values for the requested range at the requested samplerate

This Request corresponds to the one over at OpenShot/openshot-qt#2035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants