Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing Read Video Config in RE Video Config #32

Open
Olganix opened this issue May 16, 2018 · 1 comment
Open

missing Read Video Config in RE Video Config #32

Olganix opened this issue May 16, 2018 · 1 comment

Comments

@Olganix
Copy link
Contributor

Olganix commented May 16, 2018

it's normally the next function as sub_408880().

@JayFoxRox
Copy link
Member

JayFoxRox commented May 16, 2018

Please provide proper function names (not "the next function as" - jut tell us which one you mean). Then describe them in greater detail.
Also always add which version of the game you are talking about.


(The following is for the patched US version)

I've checked sub_408B60 (which follows sub_408880) and it is indeed config writer. However, that is to be expected as it's probably in the same object file during the linking. As the writer is already documented it wasn't too important to also document the parser.

Documenting more config functions is currently not necessary - as the rough pattern has been described for other config files, so we can easily document them within a minute or so. We should care about the function which are harder to identify.
The idea behind documenting the config and menus was to document the addresses to which the config is loaded.
For example, we can easily tell that dword_EC86BC stores the model detail.

If a function uses strings, It's easy to spot what most functions do. We don't need issues or reminders for those.
The real problem is documenting the internals and functions which only do logic.


Feel free to still document it properly and send a pull request. It might be a good task for a starter to restructure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants