-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video settings are not saved #160
Comments
diff --git a/com/a3d.c b/com/a3d.c
index 5cdf154..375581e 100644
--- a/com/a3d.c
+++ b/com/a3d.c
@@ -232,6 +232,13 @@ HACKY_COM_BEGIN(IA3d4, 0)
esp += 3 * 4;
HACKY_COM_END()
+// IA3d4 -> STDMETHOD_(ULONG,Release) (THIS) PURE; //2
+HACKY_COM_BEGIN(IA3d4, 2)
+ hacky_printf("p 0x%" PRIX32 "\n", stack[1]);
+ eax = 0; // FIXME: No idea what this expects to return..
+ esp += 1 * 4;
+HACKY_COM_END()
+
// IA3d4 -> STDMETHOD(GetHardwareCaps) (THIS_ LPA3DCAPS_HARDWARE) PURE; // 11
HACKY_COM_BEGIN(IA3d4, 11)
hacky_printf("GetHardwareCaps\n");
@@ -666,6 +673,13 @@ HACKY_COM_END()
+// IA3dListener -> STDMETHOD_(ULONG,Release) (THIS) PURE; //2
+HACKY_COM_BEGIN(IA3dListener, 2)
+ hacky_printf("p 0x%" PRIX32 "\n", stack[1]);
+ eax = 0; // FIXME: No idea what this expects to return..
+ esp += 1 * 4;
+HACKY_COM_END()
+
// IA3dListener -> STDMETHOD(SetPosition3f) (THIS_ A3DVAL, A3DVAL, A3DVAL) PURE; // 3
HACKY_COM_BEGIN(IA3dListener, 3)
hacky_printf("SetPosition3f\n"); |
If you want to submit changes, please send a PR. For something minor like this I'll probably just hit merge. Note that there's also a WIP branch which includes this fix: JayFoxRox#16 |
When quitting after changing video settings; then restarting the game, the previous video settings are not restored. Instead, they are returned to the initial state they were before making any changes.
This probably happens because of crashes while exiting the game:
The video config might not have been written at this point.
The text was updated successfully, but these errors were encountered: