Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for overrides when coverting #145

Open
ian-bartholomew opened this issue Jul 21, 2022 · 0 comments
Open

Allow for overrides when coverting #145

ian-bartholomew opened this issue Jul 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ian-bartholomew
Copy link
Contributor

Problem to solve

Nobl9 requires a few things that the OpenSLO spec does not support. However, for the use case of someone keeping the source of truth in OpenSLO and converting to Nobl9, we don't have a good way of providing those values, outside of manual updating.

Example:
The MetricSourceSpec here has Name and Kind that we need to add when assigning here

Proposal

It would be ideal to have a way to provide inline attributes that are not part of the OpenSLO spec to give hints to the converter to include in the output. We don't want to add these to the spec structs tho, since they are not part of the spec.

Another option is to use something like yk to merge the output with an override file, though this way is less than ideal since its brittle

@ian-bartholomew ian-bartholomew added the enhancement New feature or request label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant