-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Custom Resource Definitions (CRDs) to represent the spec #87
Comments
Related #20 |
I'm going to start looking at this and was curious as to the preferred approach, as we have a few available possibilities. From my perspective I see the following goals:
In terms of how we get there, here are the options I'm aware of:
I don't have a preference as to the process, but I'd appreciate feedback from the community as to the preferred approach. Should I be proposing a PR based on option 2, or looking to help with #32 for option 1? |
Can be an alternative to OpenSLO#20 and OpenSLO#87, or as a precursor to them. Changes: - Moved `v1alpha` structs from oslo to here - Created `v1beta1` structs to represent the current state of the spec - Removed `Service` from `v1beta` as it is not used, as far as I could tell - Renamed `kind` to `type` for `AlertCondition` to prevent confusion with `Kind` which has a different meaning
Problem to solve
At the moment there is YAML within the README defining the desired structure, and it appears the specification is embedded into https://github.com/OpenSLO/oslo
Making it difficult to grab the specification and utilize it.
Proposal
To align with the Kubernetes ecosystem, it would be great if there were CRDs that defined the various parts of the specification.
Links / references
https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/
The text was updated successfully, but these errors were encountered: