Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCommand should use strcmp instead of strstr #44

Open
spiderkeys opened this issue Jan 14, 2017 · 0 comments
Open

CCommand should use strcmp instead of strstr #44

spiderkeys opened this issue Jan 14, 2017 · 0 comments
Assignees
@spiderkeys
Labels
bug

Comments

@spiderkeys
Copy link
Contributor

https://github.com/OpenROV/openrov-software-arduino/blob/master/sketches/OpenROV2x/CCommand.cpp#L110

This should be changed to use strcmp. Currently, cockpit is sending "throttle" as a command, but "thro" is satisfying the check. This could easily cause problems if new commands are added that happen to have a common substring.
@spiderkeys spiderkeys added the bug label Jan 14, 2017
@spiderkeys spiderkeys self-assigned this Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spiderkeys spiderkeys

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spiderkeys