Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IPP Everywhere printer through IPP #201

Open
3 of 6 tasks
michaelrsweet opened this issue Jun 18, 2021 · 6 comments
Open
3 of 6 tasks

Create IPP Everywhere printer through IPP #201

michaelrsweet opened this issue Jun 18, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request priority-high
Milestone

Comments

@michaelrsweet
Copy link
Member

michaelrsweet commented Jun 18, 2021

Copied from Apple CUPS #5919

Update cupsd to support a "ppd-name" of "everywhere" to generate the PPD in the background:

  • Update cupsd to use create_local_bg_thread in add_printer when "ppd-name" is "everywhere"
  • Update lpadmin to not create PPD locally
  • Update admin.cgi to not create PPD locally
  • Update _ppdCreateWithIPP to copy the 128x128 icon as embedded data in PPD file.
  • Update cupsd/load_ppd to copy the icon data to ServerRoot/icons/PRINTERNAME.png
  • Update cupsd to expose printer icons from ServerRoot/icons
@michaelrsweet michaelrsweet added enhancement New feature or request priority-high labels Jun 18, 2021
@michaelrsweet michaelrsweet added this to the v2.4.0 milestone Jun 18, 2021
@michaelrsweet michaelrsweet self-assigned this Jun 18, 2021
@zdohnal
Copy link
Member

zdohnal commented Jul 13, 2021

P.S. commit 68506ac broke test suite, we will need to investigate further.

@zdohnal
Copy link
Member

zdohnal commented Jul 13, 2021

This error appeared after the mentioned commit:

E [13/Jul/2021:12:30:21.337402 +0200] [cups-driverd] Unable to open \"/tmp/cups-zdohnal/share/model/everywhere\" - No such    file or directory

@zdohnal
Copy link
Member

zdohnal commented Jul 13, 2021

Error log from the test run - the error happens during serving CUPS-Get-PPD request which hasn't been migrated to support everywhere model.

Currently I'm not sure whether we want to migrate this operation for everywhere or not, and if we want, how to get the ppd, because cups-driverd works with files, and _ppdCreateFromIPP() returns only char array for now.

@michaelrsweet
Copy link
Member Author

@zdohnal Not sure why I didn't catch this when I did testing, but fixed now:

[master 3a37c0d] Fix regression caused by change for Issue #201.

@zdohnal
Copy link
Member

zdohnal commented Jul 15, 2021

@michaelrsweet verified, tests are passing now. Thx!

@michaelrsweet
Copy link
Member Author

Moving the printer icon stuff to 2.5.

@michaelrsweet michaelrsweet modified the milestones: v2.4, v2.5 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-high
Projects
None yet
Development

No branches or pull requests

2 participants