Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tutorial: Demonstrate DP on DataWarehouse for #300 #346

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Koukyosyumei
Copy link

Description

This PR aims to close #300.
Although the label of #300 is "status in progress", it seems that no one is working on this issue.
This notebook consists of two parts. The first part shows how differential privacy works under the assumption that the attacker already knows almost all of the data except one record. In the second one, the attacker tries to identify one person, and the defender uses differential privacy to avoid this.

It is the first PR for me to this excellent project, so if I misunderstand something, please correct me!

Affected Dependencies

no

How has this been tested?

jupyter lab

Checklist

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Koukyosyumei Koukyosyumei changed the title first draft for #300 New Tutorial: Demonstrate DP on DataWarehouse for #300 Feb 23, 2021
@@ -143,7 +144,8 @@ def run_clang_format_diff_wrapper(args, file):
except DiffError:
raise
except Exception as e:
raise UnexpectedError("{}: {}: {}".format(file, e.__class__.__name__, e), e)
raise UnexpectedError("{}: {}: {}".format(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use f-strings here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not what I intended, and I reset the commit



expect_near = lambda expected, actual, tol: (
def expect_near(expected, actual, tol): return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to move from lambda to this new implementation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not what I intended, and I reset the commit

@Koukyosyumei
Copy link
Author

@chinmayshah99
Thanks for your review! The problems you mentioned were not what I intended. I changed some files to pass mypy tests, but it also couldn't pass ci tests. These errors during ci tests are not what this PR aims to solve, so I reset the commit. Currently, what I have added are only a notebook and csv files.

@chinmayshah99 chinmayshah99 added Type: New Feature ➕ Introduction of a completely new addition to the codebase Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes labels May 7, 2021
@chinmayshah99 chinmayshah99 added Status: Stale 🍞 Been open for a while with no activity and removed Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale 🍞 Been open for a while with no activity Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Tutorial: Demonstrate DP on DataWarehouse
2 participants