-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for test mode? #20
Comments
100% agree, I think it would be core's responsibility to pass parameters into the language pack and have that specific adaptor be in charge of what 'test mode' means in that context. Totally makes sense we've outgrown this approach. |
So what I'm envisaging is that (perhaps for now), a specific set of flags can be passed into all adaptors. And then deal with it. I'd like to at least have the idea of it not getting into state entertained, like let's imagine what that would be like (nothing more). I bring that up, as I would like to see if we can avoid having every operation having an if statement for test mode.. |
We'd provided an option for
test mode
which would try to intercept http requests made withrequest
(so... lots of language-packages until recently) but that no longer works withaxios
andrequest
is deprecated. We had used https://www.npmjs.com/package/mitm , but after a hard look it feels like this really shouldn't be the responsibility ofcore
.I'd move to drop support for test mode and let folks set up their own proxies with axios if they really want. Thoughts @stuartc , @lakhassane , @chaiwa-berian ?
The text was updated successfully, but these errors were encountered: