Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for test mode? #20

Open
taylordowns2000 opened this issue Jan 31, 2021 · 2 comments
Open

Drop support for test mode? #20

taylordowns2000 opened this issue Jan 31, 2021 · 2 comments

Comments

@taylordowns2000
Copy link
Member

We'd provided an option for test mode which would try to intercept http requests made with request (so... lots of language-packages until recently) but that no longer works with axios and request is deprecated. We had used https://www.npmjs.com/package/mitm , but after a hard look it feels like this really shouldn't be the responsibility of core.

I'd move to drop support for test mode and let folks set up their own proxies with axios if they really want. Thoughts @stuartc , @lakhassane , @chaiwa-berian ?

@stuartc
Copy link
Member

stuartc commented Jan 31, 2021

100% agree, I think it would be core's responsibility to pass parameters into the language pack and have that specific adaptor be in charge of what 'test mode' means in that context.

Totally makes sense we've outgrown this approach.

@stuartc
Copy link
Member

stuartc commented Jan 31, 2021

So what I'm envisaging is that (perhaps for now), a specific set of flags can be passed into all adaptors. And then deal with it.

I'd like to at least have the idea of it not getting into state entertained, like let's imagine what that would be like (nothing more).

I bring that up, as I would like to see if we can avoid having every operation having an if statement for test mode..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants