Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about reader_netCDF_CF_unstructured.py #1287

Open
helena2281 opened this issue Apr 23, 2024 · 1 comment
Open

Question about reader_netCDF_CF_unstructured.py #1287

helena2281 opened this issue Apr 23, 2024 · 1 comment

Comments

@helena2281
Copy link

I have some questions about reader_netCDF_CF_unstructured.py code.

If you look at the get_variable function, there is a slight difference between node_variable and face_variable in the part that fetches the data at the closest point to the particle position.
The node_variables says to extract the required data using sigma_ind when dvar.dimensions has 'siglev'.
On the other hand, face_variables use sigma_ind to extract data when 'siglay' is in the variable dimension.

In my opinion, if node_variables, face_variables, or depth dimensions exist, they can all use 'siglay' the same, but what made them set them differently? Is there any special reason?

face_variable interpolating
image

node_variable interpolating
image

@gauteh
Copy link
Member

gauteh commented Apr 23, 2024

I think I made this change because siglay was for face_variables and siglev was for node variables, otherwise the dimensions did not match up. But it has been a while since I did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants