Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use public destructors (unless you really need them) #351

Closed
pavel-kirienko opened this issue Apr 24, 2024 · 1 comment
Closed

Do not use public destructors (unless you really need them) #351

pavel-kirienko opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
class-requirement Issue that can be traced back to a design requiement domain-production Pertains to the shippable code rather than any scaffolding priority-high

Comments

@pavel-kirienko
Copy link
Member

We don't seem to need them so far. Use interface_ptr instead.

@pavel-kirienko pavel-kirienko added domain-production Pertains to the shippable code rather than any scaffolding priority-high class-requirement Issue that can be traced back to a design requiement labels Apr 24, 2024
@serges147
Copy link
Collaborator

@pavel-kirienko I think this issue has been addressed. Would you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class-requirement Issue that can be traced back to a design requiement domain-production Pertains to the shippable code rather than any scaffolding priority-high
Projects
None yet
Development

No branches or pull requests

2 participants