Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colabpersonID to sensitive data #496

Open
phavekes opened this issue Nov 30, 2024 · 2 comments
Open

colabpersonID to sensitive data #496

phavekes opened this issue Nov 30, 2024 · 2 comments

Comments

@phavekes
Copy link
Member

This issue is imported from pivotal - Originaly created at Apr 13, 2022 by Pieter van der Meulen

The colabpersonID should be removed when a user is deprovisioned. Therefore this element should be moved to the sensitive data stream. This requires a rewrite of the evenstream in de database

@phavekes
Copy link
Member Author

Preferably we would utilize a Doctrine migration for this. 

Some changes that are required:

  • Update the Events and SensitiveData concepts in the places where the sensitive data is used. For example: move the NameId in the IdentityCreated event to the SensitiveData. Are new versions of the events required?
  • Run the data migration. This should update the payload data of the events and move the data to the matching sensitive data entry. Verify: are there events that currently not have sensitive data but would have after this change? In that case. Sensitive data entry might need to be created for that identity.
  • This migration is hard to test programatically, but as a test, at least an event replay should be performed. To test if everything works afterwards. And all data is stored correctly in the new situation.

An example of an event rewrite added last year:
https://github.com/OpenConext/Stepup-Middleware/blob/07cf406e8f872c3b57dc43ac2c02ae359129b003/src/Surfnet/Migrations/Version20210610131957.php

#329 (Michiel Kodde - Apr 13, 2022)

@phavekes
Copy link
Member Author

Will this be the moment that a prod event replay is required to also rid the projections of this sensitive data? (Michiel Kodde - Apr 13, 2022)

@phavekes phavekes removed their assignment Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

1 participant