Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default-initialize BatchElementError.code #1298

Closed
Tracked by #859
feltech opened this issue Apr 18, 2024 · 0 comments · Fixed by #1321
Closed
Tracked by #859

Default-initialize BatchElementError.code #1298

feltech opened this issue Apr 18, 2024 · 0 comments · Fixed by #1321
Labels
bug Something isn't working
Milestone
v1.0.0 - Essential

Comments

@feltech
Copy link
Member

feltech commented Apr 18, 2024 •
edited by elliotcmorris

Otherwise the enum will be garbage if not set.
@feltech feltech mentioned this issue Apr 18, 2024
Open
@feltech feltech added this to the v1.0.0 milestone Apr 18, 2024
@elliotcmorris elliotcmorris added the bug Something isn't working label Apr 18, 2024
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 3, 2024
@feltech
[Tests] Check conveniences non-response case
5b2c8ee 
Part of OpenAssetIO#1169. Relates to OpenAssetIO#1069, OpenAssetIO#1298, OpenAssetIO#1299. We missed tests for our
convenience signatures in the case where the manager plugin doesn't call
a callback. I.e. the default return value(s).

Some of these default return values seem rather unfortunate and future
work will see if these can be improved.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 3, 2024
@feltech
[Core] Set code for default constructed BatchElementError
ca6aec8 
Part of OpenAssetIO#1169. Closes OpenAssetIO#1298. A default-initialised `enum class` variable
is zero, but our codes start at 128, i.e. `kUnknown`. This meant the
default-initialisation of a `BatchElementError` gave an invalid object.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 3, 2024
@feltech
[Core] Set code for default constructed BatchElementError
773e931 
(Re)discovered during OpenAssetIO#1169. Closes OpenAssetIO#1298. A default-initialised `enum
class` variable is zero, but our codes start at 128, i.e. `kUnknown`.
This meant the default-initialisation of a `BatchElementError` gave an
invalid object.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 3, 2024
@feltech
[Tests] Convenience sigs non-response test cases
d947eb2 
Discovered during OpenAssetIO#1169. Relates to OpenAssetIO#1069, OpenAssetIO#1298, OpenAssetIO#1299. We missed tests
for our convenience signatures in the case where the manager plugin
doesn't call a callback. I.e. the default return value(s).

Some of these default return values seem rather unfortunate and future
work will see if these can be improved.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 3, 2024
@feltech
[Tests] Convenience sigs non-response test cases
08e3fc5 
Discovered during OpenAssetIO#1169. Relates to OpenAssetIO#1069, OpenAssetIO#1298, OpenAssetIO#1299. We missed tests
for our convenience signatures in the case where the manager plugin
doesn't call a callback. I.e. the default return value(s).

Some of these default return values seem rather unfortunate and future
work will see if these can be improved.

Signed-off-by: David Feltell <[email protected]>
@feltech feltech mentioned this issue Jun 3, 2024
Merged
2 tasks
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 3, 2024
@feltech
[Core] Set code for default constructed BatchElementError
f44a4e8 
(Re)discovered during OpenAssetIO#1169. Closes OpenAssetIO#1298. A default-initialised `enum
class` variable is zero, but our codes start at 128, i.e. `kUnknown`.
This meant the default-initialisation of a `BatchElementError` gave an
invalid object.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 3, 2024
@feltech
[Tests] Convenience sigs non-response test cases
e9a251a 
Discovered during OpenAssetIO#1169. Relates to OpenAssetIO#1069, OpenAssetIO#1298, OpenAssetIO#1299. We missed tests
for our convenience signatures in the case where the manager plugin
doesn't call a callback. I.e. the default return value(s).

Some of these default return values seem rather unfortunate and future
work will see if these can be improved.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 11, 2024
@feltech
[Core] Set code for default constructed BatchElementError
cb0ffa4 
(Re)discovered during OpenAssetIO#1169. Closes OpenAssetIO#1298. A default-initialised `enum
class` variable is zero, but our codes start at 128, i.e. `kUnknown`.
This meant the default-initialisation of a `BatchElementError` gave an
invalid object.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 11, 2024
@feltech
[Tests] Convenience sigs non-response test cases
2a71795 
Discovered during OpenAssetIO#1169. Relates to OpenAssetIO#1069, OpenAssetIO#1298, OpenAssetIO#1299. We missed tests
for our convenience signatures in the case where the manager plugin
doesn't call a callback. I.e. the default return value(s).

Some of these default return values seem rather unfortunate and future
work will see if these can be improved.

Signed-off-by: David Feltell <[email protected]>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jun 13, 2024
@feltech
[Tests] Convenience sigs non-response test cases
ae1de37 
Discovered during OpenAssetIO#1169. Relates to OpenAssetIO#1069, OpenAssetIO#1298, OpenAssetIO#1299. We missed tests
for our convenience signatures in the case where the manager plugin
doesn't call a callback. I.e. the default return value(s).

Some of these default return values seem rather unfortunate and future
work will see if these can be improved.

Signed-off-by: David Feltell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenAssetIO Development
Status: Done
Milestone
v1.0.0 - Essential
Development

Successfully merging a pull request may close this issue.

entityExists conveniences feltech/OpenAssetIO
2 participants
@feltech @elliotcmorris