Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Progress is bad experience #600

Open
ryjen opened this issue Mar 25, 2024 · 6 comments · Fixed by #602
Open

Upload Progress is bad experience #600

ryjen opened this issue Mar 25, 2024 · 6 comments · Fixed by #602
Assignees
Labels
bug Needs QA Should be done now, please test! Priority: Medium
Milestone

Comments

@ryjen
Copy link

ryjen commented Mar 25, 2024

Describe the bug

When uploading a file to the internet archive, often the progress will remain indeterminate or stuck on a percentage

When the upload completes, there is a long delay, and will not show complete until the user navigates away and returns to screen

Sometimes the image display is janky

We upload multiple files which the progress is either not handled or resets:

  • content
  • metadata
  • proof files

To Reproduce
Steps to reproduce the behavior:

  1. Upload a file (IA)
  2. Watch progress on main screen
  3. See error

Expected behavior

  • indeterminate progress initially
  • progress starts happening with percentage
  • when file completes progress is gone, and header updated
  • all state shifts happen fluidly and in reasonable time

Environment (please complete the following information):

  • OS version: Any
  • Device: Any
  • App Version 0.3.1 or IA refactor

Additional context

  • Should run performance monitor, you will likely see that the progress reporting is taking up way too much resources

  • broadcasts could be ordered or synced to ensure state

  • the broadcasts to update progress should not contain db writes for a simple progress value

  • the UI display refreshes are either queued and cannot keep up or happening too fast

@ryjen ryjen added the bug label Mar 25, 2024
@ryjen ryjen changed the title IA: spinners Upload Progress is janky Mar 25, 2024
@ryjen ryjen changed the title Upload Progress is janky Upload Progress is bad experience Mar 25, 2024
@ryjen ryjen linked a pull request Mar 25, 2024 that will close this issue
@ryjen ryjen added the Needs QA Should be done now, please test! label Mar 25, 2024
@ryjen ryjen added this to the Critical Bugs milestone Mar 25, 2024
@ryjen ryjen assigned vanichitkara and unassigned ryjen Mar 26, 2024
@vanichitkara
Copy link

@ryjen @foundscapes I am facing issues while uploading files to IA. When the files are uploading, and I click on Edit, the upload freezes and doesn't get retried from the Edit queue. When I retry from the home screen, it gets retried. Attaching video for reference

IABug.mp4

OS: Android 14
Device: OnePlus 11R
version: 0.3.3

@ryjen
Copy link
Author

ryjen commented Mar 27, 2024

@vanichitkara thank you,definately having trouble reproducing this one...

Does it happen consistently? Or does it vary?

EDIT: Ok I got the crash at least..... resolving....

@vanichitkara
Copy link

@ryjen This is happening consistently for me

@foundscapes
Copy link

@vanichitkara can you retest this since we updated the IA? it may be resolved, ty!

@foundscapes
Copy link

@purvi-ranawat please test ty!

@purvi-ranawat
Copy link

@foundscapes : Internet Archive is down right now. So, not able to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs QA Should be done now, please test! Priority: Medium
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants