Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Game tag System #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TheMeinerLP
Copy link
Collaborator

@TheMeinerLP TheMeinerLP commented May 26, 2024

Proposed changes

Fixes #39

This PR aims to replace the old game tag system from Minestom. The old system did not use generation, but a hybrid. During testing it was noticed that this causes errors.
By adding a generic tag structure to read all values from the files, we make it easier to generate the tags

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@TheMeinerLP TheMeinerLP self-assigned this May 26, 2024
@TheMeinerLP TheMeinerLP requested a review from theEvilReaper May 26, 2024 20:35
@TheMeinerLP TheMeinerLP requested a review from Codestech1 May 27, 2024 15:06
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

@Codestech1 Codestech1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine, however we need to have game event tags implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise Gametags
2 participants