You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current code for Dev OMNI (formerly Dev MSC) calculations (omnicore.cpp: calculate_and_update_devmsc()) should be improved in one or more of the following ways:
Refactor for clarity and improve comments -- see PR #1246 which is a first step
Total Dev OMNI value is hard-coded for Omni main net and is not verified anywhere (that I know of) against the actual crowdsale OMNI totals
The calculations use floating-point (double) and may have significant rounding errors or be platform-dependent
More unit-test and functional tests
The specification itself should probably be revised and/or clarified -- token issuance should use an algorithm similar to the Bitcoin issuance (i.e. using block height rather than timestamps and specifying per-block issuance directly in satoshis/willetts)
The text was updated successfully, but these errors were encountered:
The current code for Dev OMNI (formerly Dev MSC) calculations (
omnicore.cpp
:calculate_and_update_devmsc()
) should be improved in one or more of the following ways:double
) and may have significant rounding errors or be platform-dependentThe text was updated successfully, but these errors were encountered: