Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new STO negative test sending OMNI #39

Open
marv-engine opened this issue Jan 29, 2015 · 3 comments
Open

new STO negative test sending OMNI #39

marv-engine opened this issue Jan 29, 2015 · 3 comments

Comments

@marv-engine
Copy link

See new row 15 in Send-To-Owners Tests

It tests the condition where an address tries to send too many MSC so that the address does not have enough available MSC remaining to pay the transfer fee for all the MSC owners that would receive a portion of the STO amount.

This should be an invalid transaction.

@dexX7
Copy link
Member

dexX7 commented Jan 29, 2015

This one makes me crazy.. :) The test doesn't make it's point, if there are no owners, so I created two, which works in the very first run perfectly, but in the following rounds the test failed and after starting fresh the behavior was somewhat random, until I realized: if there is one owner with a large amount, then the owner gets all 3 willets and the transaction is valid.

Can you think of another way to test it, besides having at least one owner and where the STO amount equals actor's whole balance?

@dexX7
Copy link
Member

dexX7 commented Jan 29, 2015

See: sto-testplan.tsv#L8

The actor starts with 0.000001 TMSC (see #7) and there is one owner with 1.0 TMSC. The amount STO is 0.000001 TMSC. The resulting transaction should be invalid, because the actor has not enough TMSC to pay the fee.

@marv-engine
Copy link
Author

What I'm trying to test is the situation where the sender tries to send a portion (not all) of his MSC but then doesn't have enough MSC left to pay the transfer fee for all the owners who would get a portion of the total distribution. This test should be different than where the sender has 0 available MSC to pay any transfer fees because the condition I'm testing is not known before the first loop identifying which owners get a portion of the distribution.

This may be an extreme edge case.

@msgilligan msgilligan changed the title new STO negative test sending MSC new STO negative test sending OMNI Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants