Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't merge #519

Open
salsawij opened this issue Feb 12, 2023 · 11 comments
Open

can't merge #519

salsawij opened this issue Feb 12, 2023 · 11 comments

Comments

@salsawij
Copy link

it always says this Make sure that only one line was affected, how am I suppose to resolve this?

@rdwz
Copy link
Contributor

rdwz commented Feb 17, 2023

I think this is because both zone files lack a newline at the end

@ririko5834
Copy link
Contributor

I have the same problem

@py660
Copy link
Contributor

py660 commented Mar 6, 2023

If they both lack a newline at the end, how are they different?

@cjabb
Copy link

cjabb commented Mar 10, 2023

I think this is because both zone files lack a newline at the end

yeah that's the issue but it seems even when adding a newline the error still occurs.

@ririko5834
Copy link
Contributor

@olivr-bot

@ririko5834
Copy link
Contributor

@politician take a look at it

@py660
Copy link
Contributor

py660 commented Mar 11, 2023

I found that if you use github.dev, everything works perfectly.

@ririko5834
Copy link
Contributor

It didnt work for me there too

@ririko5834
Copy link
Contributor

Finally got it, you need to add your line between other lines, not at the end of the file

@ririko5834
Copy link
Contributor

Didnt work :( https://github.com/Olivr/free-domain/pull/645/files only 1 line is affected. That check isn't working well, it should be fixed or removed that only 1 line affected checking

@jaymineh
Copy link
Contributor

Same issue I'm still having. Can someone look into this please? @olivr-bot @politician

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants