Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows external repo when viewing local modules in Python #1366

Open
gasparyanartur opened this issue Sep 23, 2021 · 6 comments
Open

Shows external repo when viewing local modules in Python #1366

gasparyanartur opened this issue Sep 23, 2021 · 6 comments
Labels

Comments

@gasparyanartur
Copy link

gasparyanartur commented Sep 23, 2021

Expected Behavior

Given a file structure that looks like this:

image

Inspecting an import statement from a module should show the module in the current repo

image

What actually happened?

image

An external, public repository is linked instead of the local module.

URL

No response

Anything else we should know?

No response

@stefanbuck
Copy link
Member

Thanks for filling this issue. This is indeed a bug. Previously there was no option to handle such cases, but with the (not so new) architecture this should be possible with some work. Are you interested in working on a fix? I'm more than happy to guide you through the required changes.

@gasparyanartur
Copy link
Author

gasparyanartur commented Sep 24, 2021 via email

@stefanbuck
Copy link
Member

Sorry, I'm a bit slow and quite busy right now. Starting next week I should have more time. In the meantime, please take a look at our End 2 End test guide. Maybe you're able to prepare a few test cases.

@gasparyanartur
Copy link
Author

I'll see what I can do!

@gasparyanartur
Copy link
Author

So I looked through the repo, and it seems like you already have test cases for Python on the better-python-support branch. How come they aren't merged with the main branch?

@stefanbuck
Copy link
Member

Good shout. To be honest I haven't been very active on OctoLinker and I forgot about that PR. I'll have a look at the PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants