Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Needle with Objection usage. #1764

Merged
merged 25 commits into from
Jul 3, 2020
Merged

Conversation

karolpiateknet
Copy link
Contributor

Hello,

I have updated the usage of Needle with Objection. However I had some problems with the Keyboards cache and the Custom URL's. It is still need to be fixed.

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR is partialy closing the #1409

@karolpiateknet
Copy link
Contributor Author

@sushi2k Could you review changes?

@sushi2k
Copy link
Collaborator

sushi2k commented Jun 13, 2020

Thanks for the PR @karolpiateknet! I will look into it next week.

Copy link
Collaborator

@sushi2k sushi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay to review your PR @karolpiateknet . Thanks for the additions! Please have a look at the comments. Once we addressed we are good to go!

Document/0x06b-Basic-Security-Testing.md Show resolved Hide resolved
Document/0x06c-Reverse-Engineering-and-Tampering.md Outdated Show resolved Hide resolved
Document/0x06d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Document/0x06d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Document/0x06d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Document/0x06d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Document/0x06d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Document/0x06d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Document/0x06f-Testing-Local-Authentication.md Outdated Show resolved Hide resolved
@karolpiateknet
Copy link
Contributor Author

@sushi2k Thanks for the review, I have applied all suggested changes :)

Copy link
Collaborator

@sushi2k sushi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome enhancement! Thanks for the transition from Needle to objection @karolpiateknet.

There is one tiny fix needed, then we are ready to merge :-)

Document/0x06d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sushi2k sushi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny fix needed

@karolpiateknet
Copy link
Contributor Author

Fixed, but need another approved :)

@karolpiateknet karolpiateknet requested a review from sushi2k June 29, 2020 04:57
Copy link
Collaborator

@sushi2k sushi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Approved!

@sushi2k
Copy link
Collaborator

sushi2k commented Jul 3, 2020

Thanks for the update @karolpiateknet and migrating from needle to objection.

@sushi2k sushi2k merged commit 91a4823 into OWASP:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants