-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the Needle with Objection usage. #1764
Conversation
Merge master
@sushi2k Could you review changes? |
Thanks for the PR @karolpiateknet! I will look into it next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay to review your PR @karolpiateknet . Thanks for the additions! Please have a look at the comments. Once we addressed we are good to go!
Document/0x06j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
Co-authored-by: Sven <[email protected]>
@sushi2k Thanks for the review, I have applied all suggested changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome enhancement! Thanks for the transition from Needle to objection @karolpiateknet.
There is one tiny fix needed, then we are ready to merge :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny fix needed
Co-authored-by: Sven <[email protected]>
Fixed, but need another approved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Approved!
Thanks for the update @karolpiateknet and migrating from needle to objection. |
Hello,
I have updated the usage of Needle with Objection. However I had some problems with the Keyboards cache and the Custom URL's. It is still need to be fixed.
Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:
If your PR is related to an issue. Please end your PR test with the following line:
This PR is partialy closing the #1409