Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Risk - Sensitive Data Stored Unencrypted in Shared Storage Requiring No User Interaction [data-unencrypted-shared-storage-no-user-interaction] #2545

Open
4 tasks
cpholguera opened this issue Feb 5, 2024 · 2 comments · May be fixed by #2594

Comments

@cpholguera
Copy link
Collaborator

cpholguera commented Feb 5, 2024

Description

Create a new risk for "Sensitive Data Stored Unencrypted in Shared Storage Requiring No User Interaction (MASVS-STORAGE-1)" using the following information:

Sensitive data may be stored in external locations (e.g. external storage, public folders, etc.) without encryption and may be accessible to other apps.

Create "risks/MASVS-STORAGE/1-***-****/data-unencrypted-shared-storage-no-user-interaction/risk.md" including the following content:

---
title: Sensitive Data Stored Unencrypted in Shared Storage Requiring No User Interaction
alias: data-unencrypted-shared-storage-no-user-interaction
platform: [android]
profiles: [L1, L2]
mappings:
  masvs-v1: [MSTG-STORAGE-2]
  masvs-v2: [MASVS-STORAGE-1]
  mastg-v1: [MASTG-TEST-0052, MASTG-TEST-0001]

---

## Overview

## Impact

## Modes of Introduction

## Mitigations

To complete the sections follow the guidelines from Writing MASTG Risks & Tests

When creating the corresponding tests, use the following areas to guide you:

  • in scoped storage (external storage, Android)
  • in external storage (public folders e.g. SD card, Photos, Downloads, Caches, etc.)
  • in external caches
  • in app-crafted backups

MASTG v1 Refactoring:

If the risk has a MASVS v1 ID, you can use it to search for related tests in the MASTG and use them as input to define your risks and associated tests.

Acceptance Criteria

  • The risk has been created in the correct directory (risks/MASVS-STORAGE/1-***-****/data-unencrypted-external/risk.md)
  • The risk content follows the guidelines
  • At least one GitHub Issue has been created for the corresponding tests (derived from "Modes of Introduction")
  • The risk indicates the related MASTG v1 tests in its metadata.
@titze
Copy link
Collaborator

titze commented Feb 6, 2024

Shouldn't

in app-crafted backups

be part of #2542 (Sensitive Data Not Excluded From Backup)?

@cpholguera
Copy link
Collaborator Author

cpholguera commented Feb 6, 2024

You are right @titze. Actually I'd say that belongs to #2541

I'll update that, thank you!

@cpholguera cpholguera changed the title New Risk - Sensitive Data Stored Unencrypted in External Locations [data-unencrypted-external] New Risk - Sensitive Data Stored Unencrypted in Shared Storage Requiring No User Interaction [data-unencrypted-shared-storage-no-user-interaction] May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment