Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpd proxy still buggy #3825

Open
johrstrom opened this issue Sep 24, 2024 · 0 comments
Open

httpd proxy still buggy #3825

johrstrom opened this issue Sep 24, 2024 · 0 comments
Labels
bug Existing functionality not working as expected component/mod_ood_proxy
Milestone
3.1

Comments

@johrstrom
Copy link
Contributor

While testing out 3.1.8 I found that the updates made in #3728 and #3776 still are not enough.

You can see here the ?dark=0&refresh=1 is being url encoded and added to the URL, while they appear again correctly as ?dark=0&refresh=1. Of course Rstudio returns a 404 here because it thinks that's still a part of the URL.

2024-09-24T17:37:11.332015Z [rserver] DEBUG - Start server proxy request GET /theme/default/solarized_light.rstheme%3Fdark=0&refresh=1?dark=0&refresh=1 (johrstrom:113) for local stream: /tmp/run/rstudio-rsession/johrstrom-d
2024-09-24T17:37:11.334152Z [rserver] DEBUG -- sent server proxy response for: /theme/default/solarized_light.rstheme%3Fdark=0&refresh=1?dark=0&refresh=1 (johrstrom:113) in 0.2s id:: 404
@johrstrom johrstrom added bug Existing functionality not working as expected component/mod_ood_proxy labels Sep 24, 2024
@johrstrom johrstrom added this to the 3.1 milestone Sep 24, 2024
@johrstrom johrstrom mentioned this issue Sep 24, 2024
Open
johrstrom added a commit that referenced this issue Oct 3, 2024
@giuliolibrando @johrstrom
Update node_proxy.lua - Fix for interactive apps not working (#3791)
7e2ab8b 
Fix node_proxy.lua for more issues related to #3730. Specifically #3825 where URIs with query parameters are not being passed correctly.

---------

Co-authored-by: Jeff Ohrstrom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing functionality not working as expected component/mod_ood_proxy
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
1 participant
@johrstrom