BatchConnect::App test for malformed YAML incorrect

[Oglopf]

While working on #221 I noticed a test written that purports to check for malformed YAML already:

ondemand/apps/dashboard/test/models/batch_connect/app_test.rb

Lines 16 to 24 in ee50a5d

	test "app with malformed form.yml" do
	Dir.mktmpdir { |dir|
	r = PathRouter.new(dir)
	r.path.join("form.yml").write("--x-\nnot a valid form yaml")
	app = BatchConnect::App.new(router: r)
	assert ! app.valid?
	}
	end

However, this is really only checking if the app is valid?. As implemented now, the BatchConnect::App#valid? method does not check for malformed YAML, it only ensures that the form key is an Array and attributes is a Hash:

ondemand/apps/dashboard/app/models/batch_connect/app.rb

Lines 196 to 212 in ee50a5d

	# Whether this is a valid app the user can use
	# @return [Boolean] whether valid app
	def valid?
	if form_config.empty?
	false
	elsif !form_config.fetch(:form, []).is_a?(Array)
	@validation_reason = I18n.t('dashboard.batch_connect_invalid_form_array')
	false
	elsif !form_config.fetch(:attributes, {}).is_a?(Hash)
	@validation_reason = I18n.t('dashboard.batch_connect_invalid_form_attributes')
	false
	elsif configured_clusters.any?
	clusters.any?
	else
	true
	end
	end

Fix

Rename this test to check if an batch connect app is valid?.

Make test in #221 ensure the YAML and ERB errors are raised correctly instead of silent fails.