Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Woosync total delta" calculations causes SQL error in invoice list #115

Open
marc-dll opened this issue Nov 9, 2023 · 0 comments
Open

Comments

@marc-dll
Copy link
Contributor

marc-dll commented Nov 9, 2023

At least up to Dolibarr v16, the calculation of the column "Woosync total delta" in invoice list causes an SQL error.

Up to this version, Dolibarr builds the SQL query to count objects in the list by replacing info the query that fetches the results.

This replacement is peculiar, and the way it is done doesn't allow the + sign to be there... which your module does :/

See https://github.com/Dolibarr/dolibarr/blob/16.0/htdocs/compta/facture/list.php#L871 to see what I mean.

I didn't try in Dolibarr v17+, as the way this is done is different, I guess this works there.

I created a PR in the core to try to fix the underlying issue : Dolibarr/dolibarr#26525. In the eventuality that it is merged, you have nothing to do ! But else, there is a workaround to be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant