Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers in Ogre framework on macOS don't have Threading subfolder #2926

Open
danielsefton opened this issue Aug 22, 2023 · 1 comment
Open

Comments

@danielsefton
Copy link

danielsefton commented Aug 22, 2023

System Information

  • Ogre Version: 14.0.1 & 13.6.5
  • Operating System / Platform: macOS Ventura
  • RenderSystem: N/A

Detailed description

When OGRE_BUILD_LIBS_AS_FRAMEWORKS is set in CMake on macOS, it builds Ogre as a framework, and in this framework is a Headers folder.

It would be convenient to be able to set the header search path to this directory in an Ogre project.

However, due to the threading header files not being inside a Threading subfolder in the framework, I can't do this. I have to manually copy across the Ogre includes alongside the framework every time, which can lead to mismatches.

I don't know if a Threading subfolder should be added to the framework itself, or if the threading header files should just be moved to the root includes folder, either solution would work. I think just adding a subfolder to the framework would not be as much of a breaking change.

@paroj
Copy link
Member

paroj commented Aug 22, 2023

I think just adding a subfolder to the framework would not be as much of a breaking change.

sounds good. Feel free to create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants