Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build logs #524

Open
pnodet opened this issue Oct 4, 2023 · 2 comments
Open

Clean up build logs #524

pnodet opened this issue Oct 4, 2023 · 2 comments

Comments

@pnodet
Copy link

pnodet commented Oct 4, 2023

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch [email protected] for the project I'm working on.

We use nextjs to build a static site using your packages and it works great but on build the logs are filled with blocks info that are not relevant for me, and maybe for many apart from you on debugs. Would you consider removing this?

Thanks!

Here is the diff that solved my problem:

diff --git a/node_modules/notion-compat/build/index.js b/node_modules/notion-compat/build/index.js
index 4d51e77..c23ecbc 100644
--- a/node_modules/notion-compat/build/index.js
+++ b/node_modules/notion-compat/build/index.js
@@ -692,7 +692,6 @@ var NotionCompatAPI = class {
     let blocks = [];
     let cursor;
     do {
-      console.log("blocks.children.list", { blockId, cursor });
       const res = await this.client.blocks.children.list({
         block_id: blockId,
         start_cursor: cursor

This issue body was partially generated by patch-package.

@pnodet
Copy link
Author

pnodet commented Oct 4, 2023

Sorry, all good this was fixed in #499

@pnodet pnodet closed this as completed Oct 4, 2023
@pnodet
Copy link
Author

pnodet commented Oct 13, 2023

This issue should be fixed in v6.16.1 but npm is still at 6.16.0

@pnodet pnodet reopened this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant