Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Cypress tests to TypeScript #18

Open
NoriSte opened this issue Jun 26, 2019 · 6 comments
Open

Move the Cypress tests to TypeScript #18

NoriSte opened this issue Jun 26, 2019 · 6 comments

Comments

@NoriSte
Copy link
Owner

NoriSte commented Jun 26, 2019

Today I imported this plugin into a TypeScript-based Cypress project. TS did not like the old definition (that's why I fixed it with #17 ) but we must avoid that the end user discovers it himself.

That's why I propose to move the Cypress test to TypeScript. @allevo do you want to do that? 👋

@Lukaszli
Copy link

Pull request is already merged so could you close this issue? :)

@NoriSte
Copy link
Owner Author

NoriSte commented Oct 28, 2019

Hi @Lukaszli , the closed PR was "update the TS definition" while this one is "translate the existing cypress tests to TS" so, no, it could not be closed yet 😊

@SteveSchreiner
Copy link

awesome plugin! works like a charm :)

I just started using this and noticed that the typescript doesn't seem to be working when the waituntil() is hanging immediately off of cy ?

image

@NoriSte
Copy link
Owner Author

NoriSte commented Nov 11, 2019

HI @SteveSchreiner, thank you 😊
Could you share the TypeScript error, please? And, if possible, a repo containing just the ts-config file for Cypress and the mentioned test code?

@NoriSte
Copy link
Owner Author

NoriSte commented Dec 12, 2019

The #66 could have been prevented by converting all the tests to TypeScript.

@NoriSte
Copy link
Owner Author

NoriSte commented May 4, 2020

Cypress released 4.4.0 version including first-class TypeScript support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants