Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sqs-sink drop events when sqs sending fails #3

Open
RickardCardell opened this issue Jun 10, 2020 · 3 comments
Open

The sqs-sink drop events when sqs sending fails #3

RickardCardell opened this issue Jun 10, 2020 · 3 comments

Comments

@RickardCardell
Copy link

SqsSinkConnectorTask lack proper error handling when the sending to SQS fails. The task doesn't fail or retry upon an error. It just logs the error and keeps going.

https://github.com/Nordstrom/kafka-connect-sqs/blob/master/src/main/java/com/nordstrom/kafka/connect/sqs/SqsSinkConnectorTask.java#L91

@alessioerosferri
Copy link

Hi @RickardCardell, does this mean that the offset to Kafka is committed regardless of the successful acknowledgment of the message in SQS?

@RickardCardell
Copy link
Author

RickardCardell commented Aug 3, 2020

Hi @RickardCardell, does this mean that the offset to Kafka is committed regardless of the successful acknowledgment of the message in SQS?

Yes. Proper error handling is just not implemented yet.

@yordis
Copy link

yordis commented Nov 25, 2022

You can either send as a batch the messages to keep the throughput or commit per everything single message slowing the system down.

Inspired by this, we are doing something similar in Elixir lang, and we are facing some issues due to SQS message size and figuring out how to tune the batch size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants