From db060255cf82f19edbba31c18719f7122acc3b04 Mon Sep 17 00:00:00 2001 From: zoeyTM Date: Tue, 14 May 2024 20:16:36 -0400 Subject: [PATCH 1/2] add chainId to telemetry stats for ignition --- .../hardhat-core/src/internal/cli/analytics.ts | 15 ++++++++++++++- packages/hardhat-core/src/internal/cli/cli.ts | 3 ++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/packages/hardhat-core/src/internal/cli/analytics.ts b/packages/hardhat-core/src/internal/cli/analytics.ts index adb28618b5..19b38c5b0f 100644 --- a/packages/hardhat-core/src/internal/cli/analytics.ts +++ b/packages/hardhat-core/src/internal/cli/analytics.ts @@ -15,6 +15,7 @@ import { writeTelemetryConsent, } from "../util/global-dir"; import { getPackageJson } from "../util/packageInfo"; +import { HardhatRuntimeEnvironment } from "../../types"; import { confirmTelemetryConsent } from "./prompt"; const log = debug("hardhat:core:analytics"); @@ -58,6 +59,7 @@ interface TaskHitPayload extends AnalyticsPayload { session_id?: string; scope?: string; task?: string; + chainId?: string; }; }>; } @@ -119,7 +121,8 @@ export class Analytics { */ public async sendTaskHit( scopeName: string | undefined, - taskName: string + taskName: string, + hre: HardhatRuntimeEnvironment ): Promise<[AbortAnalytics, Promise]> { if (!this._enabled) { return [() => {}, Promise.resolve()]; @@ -130,9 +133,19 @@ export class Analytics { (scopeName === "ignition" && taskName === "deploy") || (scopeName === undefined && taskName === "deploy") ) { + let chainId: number | undefined; + try { + chainId = Number( + await hre.network.provider.request({ + method: "eth_chainId", + }) + ); + } catch {} + eventParams = { scope: scopeName, task: taskName, + chainId: chainId?.toString(), }; } diff --git a/packages/hardhat-core/src/internal/cli/cli.ts b/packages/hardhat-core/src/internal/cli/cli.ts index 967c5dc857..14aa1365fa 100755 --- a/packages/hardhat-core/src/internal/cli/cli.ts +++ b/packages/hardhat-core/src/internal/cli/cli.ts @@ -271,7 +271,8 @@ async function main() { const [abortAnalytics, hitPromise] = await analytics.sendTaskHit( scopeName, - taskName + taskName, + env ); let taskArguments: TaskArguments; From 4c1af53c2ce03729a05f4a4935dd846e64ee96e1 Mon Sep 17 00:00:00 2001 From: Zoey Date: Fri, 17 May 2024 00:59:49 -0400 Subject: [PATCH 2/2] Create afraid-buses-sort.md --- .changeset/afraid-buses-sort.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/afraid-buses-sort.md diff --git a/.changeset/afraid-buses-sort.md b/.changeset/afraid-buses-sort.md new file mode 100644 index 0000000000..6d63d7f9d8 --- /dev/null +++ b/.changeset/afraid-buses-sort.md @@ -0,0 +1,5 @@ +--- +"hardhat": patch +--- + +Add chainId to telemetry stats for ignition