-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker image size exploded with version 3.8.x #12582
Comments
oplik0
added a commit
to oplik0/NodeBB
that referenced
this issue
May 23, 2024
it really was just order of operations... resolves NodeBB#12582
julianlam
pushed a commit
that referenced
this issue
May 23, 2024
it really was just order of operations... resolves #12582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NodeBB version
v3.8.1
NodeBB git hash
f491d43
NodeJS version
v20.13.1
Installed NodeBB plugins
only defaults
Database type
MongoDB
Database version
v7.0.9
Exact steps to cause this issue
The docker image size exploded from
v3.7.x
tov3.8.x
What you expected
Image size of
v3.7.x
similar tov3.8.x
What happened instead
see above
Anything else?
This is caused by the refactored
Dockerfile
.Most size increase is caused by
chown -R ${USER}:${USER} /usr/src/app/
in aboveRUN
section.It is also bad style to do the above
COPY
statements with user/group id's which does not exist at that time, they are created later in theRUN
statement (I was surprised that this is allowed by e.g. buildkit, kaniko throws an error).The text was updated successfully, but these errors were encountered: