Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for branch button in the Legend panel #80

Open
AndrewStopchenko-SO opened this issue Sep 16, 2024 · 1 comment
Open

Add tooltip for branch button in the Legend panel #80

AndrewStopchenko-SO opened this issue Sep 16, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AndrewStopchenko-SO
Copy link

AndrewStopchenko-SO commented Sep 16, 2024

Is your feature request related to a problem? Please describe.
When longer branch names are used, the branch name gets truncated very quickly in the legend panel's branch button, and it lacks a tooltip to show the branch's full name.

Describe the solution you'd like
Please notice how the commit's SHA button has a tooltipped tooltipped-sw CSS class assigned, which displays a custom "white-on-black" tooltip, with the tooltip's content taken from the aria-label="...." attribute of that tooltipped element.

All this requires is adding the aria-label="${branchName}" attribute (source of the tooltip's content) and adding the class="... tooltipped tooltipped-sw" CSS classes to the element.

It should be possible to replicate this same functionality for the branch button pretty easily, maybe even switching the direction of the tooltip to e.g. north (tooltipped tooltipped-n, as we have blank space there anyway), please see the DevTools-hacked example below:
image

Describe alternatives you've considered
Adding a standard tooltip="${branchName}" attribute might be an alternative, but the tooltipped custom CSS tooltip results in a more fancy-looking tooltip appearance.

@mrpmohiburrahman
Copy link

Hi, @NirmalScaria,

I've implemented this feature in PR #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants