Build for mobile :) #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes bundling the sound asset so we don't look up at runtime. Also better for apps installed on desktop machines too.
(RGBA cannot have an A of 1 and R of 165) Move it to NRGBA as that is more familiar (this is what "rgba" is in CSS).
|
Is this sort of PR helpful for you @Nikeweke? I have a bunch more things that I think could add to the project if you are interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some code so that it will compile for mobile devices.
This is 100% functional on Android :) and somewhat functional on iOS (it stops counting in the background...)