Snap package is ready!!!

[soumyaDghosh]

Hi, I have made a snap for your app and I'm ready to maintain it. Would u like to check it out?

[nlogozzo]

Looks good! Thanks for maintaining it :)

[fsobolev]

@soumyaDghosh
Not only C# rewrite of the app, but also changes in #58 radically change how the app is built. I have no experience in creating snaps, so I can't help you with any instructions, but I hope I can give you some hints to update snap.

1. There's dotnet snapcraft plugin.
2. yt-dlp is now used as python module, not a separate binary, this may require some changes in building.
3. Blueprint and Just are new build dependencies.
4. just is used as some kind of build system. To build self-contained app, you can run just publish-self-contained PREFIX. If it doesn't fit your needs and you need another recipe to build snap, you can create a PR to add publish-snap recipe into justfile (there's a separate recipe for flatpak - publish-flatpak - so I see no problem in having another one for snap).

Feel free to ask any questions, I will be happy to help :)

[soumyaDghosh]

How should I build the app using just, can you give me the command?

[fsobolev]

How should I build the app using just, can you give me the command?

cd NickvisionTubeConverter.GNOME
just publish-self-contained /usr
just install INSTALL_DIR

Replace /usr with another prefix if needed. INSTALL_DIR should be the path where to install files, use whatever is appropriate for Snap. Examples for other packaging formats: for Flatpak it's / (to place everything in the flatpak root), and for AUR it's $pkgdir (to place everything in the directory from which the package is created).

[soumyaDghosh]

Let's say the INSTALL_DIR is /root/prime/, then if the prefix is kept as /usr then there will be a folder created as /root/prime/usr

[fsobolev]

Let's say the INSTALL_DIR is /root/prime/, then if the prefix is kept as /usr then there will be a folder created as /root/prime/usr

Right, and the files will be:

/root/prime/usr/bin/org.nickvision.tubeconverter
/root/prime/usr/share/applications/org.nickvision.tubeconverter.desktop
/root/prime/usr/share/org.nickvision.tubeconverter/org.nickvision.tubeconverter.gresource
/root/prime/usr/lib/org.nickvision.tubeconverter/NickvisionTubeConverter.dll
etc

[fsobolev]

@soumyaDghosh We found out that the icon we use for logs button doesn't fit the meaning in Yaru icon theme and probably some other, so in #87 it was hardcoded. Screenshot there shows how the app looks with Yaru icons, and Adwaita icon looks out of style. If you think this is an issue, the suggestion is to replace the icon in Snap package with what was used in old version of the app:

sed -i "s/tubeconverter-logs/dialog-information/g" NickvisionTubeConverter.GNOME/Blueprints/download_row.blp

This icon will probably look good no matter what Ubuntu flavor a user has installed and what the icon theme is.
But it's up to you, if you think it's okay currently you can leave it as is.

[soumyaDghosh]

I will take a look into that. Also,
Is liblttng-ust necessary for your app?

[nlogozzo]

Is liblttng-ust necessary for your app?

I've never heard of that library, nor do we download it anywhere for flatpak, so I'd say no. Unless it's a dependency for yt-dlp, but i don't think it is, but not 100% sure.

[soumyaDghosh]

Well, biggest issue is, when I'm running it, I'm getting Unhandled exception. What can be the reason behind?

[nlogozzo]

most likely resource files are not installed correctly...let me wrap the application in a try catch so it will print an error message...

[nlogozzo]

try the latest commit in main and see what error message it gives...

[soumyaDghosh]

Can I try it later?

[nlogozzo]

yeah no rush :)

[soumyaDghosh]

Actually on my way to my college and without my lappy... Rushing in😑

[soumyaDghosh]

yeah no rush :)

No, yet I'm getting Unhandled exception.

[nlogozzo]

So the latest commit in the main branch has the whole running of the application wrapped in a try catch block so you should see an error message if it's coming from Tube Converter.

[soumyaDghosh]

I think that's an issue of dotnet. BTW, can you move this to discussion?

[soumyaDghosh]

Hello, hope none of you have forgotten me...... If yesss. I'm sorry, I am sorry from my deepest for being so late. But it's never too late right? Here it's, the big picture. Enjoy... And also, love if you'd test it.

Screencast.from.2023-03-22.23-23-41.webm

[fsobolev]

Yay, it's working, great! 😃 No need to be sorry, we all are volunteering here, doing things when we have time and opportunity :) Thanks for working on snap package.
I didn't find a convenient way to use snap on my main PC with Silverblue, but in a few days I will try it on another device where it will be easier.

[soumyaDghosh]

Okay, so, currently I'm uploading this build in the edge channel, until this becomes stable. I'm not gonna make it to the stable channel. To install the latest version, if wished, users have to do
snap install tube-converter --edge

[soumyaDghosh]

To upload and list this I need to make a reuqest in the snap-store. So, anyone help me writing a better explaination about why I need to read the /usr/share/zoneinfo-icu/44. FYI, it's necessary to read it, so that, those messages like good morning, good evening can be shown.

[fsobolev]

Running TC in snap in WSL with openSUSE... 😄

[soumyaDghosh]

Wow... Didn't know that snaps really respects the system theme. Noice....

[soumyaDghosh]

Seems like this issue is there also. Can you give me the log which is in the screenshot? Actually there's an running issue within the snaps.
https://forum.snapcraft.io/t/snap-real-home-is-kinda-buggy
Looks like the same issue is here also.

[fsobolev]

Wow... Didn't know that snaps really respects the system theme. Noice....

Not sure what you mean, this is just a usual libadwaita style

Seems like this issue is there also. Can you give me the log which is in the screenshot? Actually there's an running issue within the snaps.

The issue that I see is that in file chooser home in sidebar opens $HOME/snap/tube-converter/18. The lines in screenshot like "...Desktop was removed, reassigning..." appeared because I didn't have xdg-user-dirs installed and so I didn't have all the expected dirs in home. But after I installed it, no errors and in file chooser all sidebar items (except of home) open correct folders. Also, downloading to $HOME/Videos works fine.
The full log:

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:35:54.456: Unable to acquire the address of the accessibility bus: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files. If you are attempting to run GTK without a11y support, GTK_A11Y should be set to 'none'.

(NickvisionTubeConverter.GNOME:1004): Gtk-CRITICAL **: 16:35:54.460: gtk_widget_get_parent: assertion 'GTK_IS_WIDGET (widget)' failed

(NickvisionTubeConverter.GNOME:1004): Gtk-CRITICAL **: 16:35:54.460: gtk_widget_add_css_class: assertion 'GTK_IS_WIDGET (widget)' failed

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:36:03.729: Allocating size to AdwPreferencesGroup 0x563175e81a30 without calling gtk_widget_measure(). How does the code know the size to allocate?

(NickvisionTubeConverter.GNOME:1004): Gtk-CRITICAL **: 16:36:03.735: Allocation height too small. Tried to allocate 424x0, but AdwPreferencesGroup 0x563175e81a30 needs at least 424x70.

(NickvisionTubeConverter.GNOME:1004): Gtk-CRITICAL **: 16:36:03.759: Allocation height too small. Tried to allocate 420x0, but GtkBox 0x563179188f80 needs at least 420x70.

(NickvisionTubeConverter.GNOME:1004): Gdk-WARNING **: 16:36:12.844: Compositor doesn't support moving popups, relying on remapping

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:36:13.527: Failed to load '/home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks': Error opening file /home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks: No such file or directory

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:36:13.528: Failed to load '/home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks': Error opening file /home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks: No such file or directory

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:36:18.862: Failed to load '/home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks': Error opening file /home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks: No such file or directory

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:36:18.863: Failed to load '/home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks': Error opening file /home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks: No such file or directory

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:39:25.720: Failed to load '/home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks': Error opening file /home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks: No such file or directory

(NickvisionTubeConverter.GNOME:1004): Gtk-WARNING **: 16:39:25.721: Failed to load '/home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks': Error opening file /home/user/snap/tube-converter/18/.config/gtk-3.0/bookmarks: No such file or directory

[soumyaDghosh]

That's yaru patch of libadwaita. It's not normal one. I built the libadwaita with the patch by yaru accent colors, and the result is this

[soumyaDghosh]

I should bundle the xdg-user-dirs with the snap