Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type overload for Push.Permission.request() #244

Closed
wants to merge 3 commits into from
Closed

Add type overload for Push.Permission.request() #244

wants to merge 3 commits into from

Conversation

Jicmou
Copy link

@Jicmou Jicmou commented Feb 19, 2020

Fixes #243

@theLufenk
Copy link
Collaborator

@Jicmou Thank you for this.
There seems to be a test failing. Can you look into it please.

@Nickersoft LGTM. Can be merged.

theLufenk
theLufenk previously approved these changes Feb 19, 2020
@Jicmou
Copy link
Author

Jicmou commented Feb 19, 2020

@theLufenk Thanks for approving.

I can reproduce the failing CI on master. Run the following commands:

npm run test
// passing
npm run build
// builds sucessfully
npm run test
// failing

I ran the first two commands before commiting, as stated in the CONTRIBUTING.md, Travis ran the third.

I could submit my PR without the build though, as index.d.tshas no impact on the build.

@theLufenk
Copy link
Collaborator

@Nickersoft Over to you.

@theLufenk
Copy link
Collaborator

nudge @Nickersoft

@Jicmou Jicmou closed this May 16, 2023
@Jicmou Jicmou deleted the type-overload-for-push-permission-request branch May 16, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types overload missing for Push.Permission.request()
3 participants